yuqi1129 commented on issue #12149: URL: https://github.com/apache/gravitino/issues/12149#issuecomment-5757851541
Closing: the acceptance criteria are met by the current code. `BaseEntityCache.isCacheable` is the single policy, `put` is `final` so every implementation (Caffeine, and Redis in #13106 which extends `BaseEntityCache`) goes through it, new entity types are non-cacheable until added to the allowlist, and `TestBaseEntityCache#testIsCacheableAcceptsOnlyApprovedTypes` asserts every `EntityType`. The one open item — documenting the managed vs. connector-backed split and removing the "cosmetic" wording — is item 5 of #12377. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
