danhuawang opened a new issue, #13461:
URL: https://github.com/apache/gravitino/issues/13461

   ### What would you like to be improved?
   
   OSS connector images do not ship the Docker-context `README.md` that 
documents install and usage:
   
   | Image | `dev/docker/.../README.md` in image? |
   |-------|--------------------------------------|
   | `apache/gravitino-trino-connector` | No |
   | `apache/gravitino-flink-connector` | No |
   | `apache/gravitino-spark-connector` | No |
   
   Dockerfiles only `COPY` connector packages, the entrypoint, and `/licenses`. 
They do not `COPY README.md`.
   
   Notes:
   - Trino version bands already include the **repo root** `README.md` via 
`assembleTrinoConnector` (`/connectors/trino-*/README.md`). That is not the 
connector image README under `dev/docker/trino-connectors/README.md`.
   - Flink/Spark images only have JARs under `/connectors/` plus `/licenses`.
   - This issue is about files **inside the image**, not Docker Hub overview 
sync.
   
   Companion Enterprise issue: same change for 
`datastrato/enterprise-*-connector` in datastrato/gravitino-enterprise (will 
link after creation).
   
   ### How should we improve?
   
   1. In these Dockerfiles, `COPY README.md /README.md`:
      - `dev/docker/trino-connectors/Dockerfile`
      - `dev/docker/flink-connectors/Dockerfile`
      - `dev/docker/spark-connectors/Dockerfile`
   2. Keep existing `/licenses` and Trino band `LICENSE` / `NOTICE` / 
`README.md` behavior unchanged.
   3. Optionally note in each Docker README that the image ships `/README.md`.
   
   ### Scope
   
   - [ ] `apache/gravitino-trino-connector`
   - [ ] `apache/gravitino-flink-connector`
   - [ ] `apache/gravitino-spark-connector`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to