bharos commented on code in PR #13464: URL: https://github.com/apache/gravitino/pull/13464#discussion_r4079627005
########## dev/docker/trino-connectors/README.md: ########## @@ -181,57 +181,78 @@ configure Basic or OAuth2. In the cluster this is usually `http://{service}.{namespace}.svc.cluster.local:8090`. A published HTTPS URL works the same way; it is not tied to the auth type. +`gravitino.metalake` is optional. Omit it (or leave it empty) to load catalogs +from every metalake. Set it when you want a single metalake only. + `gravitino.client.authType` accepts `simple`, `basic`, `oauth2`, or `kerberos`. The OAuth2 token path key is `gravitino.client.oauth2.path`. ### Basic +On a multi-node Trino cluster, also map the password to an env var (see +[Worker credentials](#worker-credentials-on-a-distributed-cluster)) and set +that env var on every pod. + ```properties connector.name=gravitino gravitino.uri=http://gravitino.example.svc.cluster.local:8090 -gravitino.metalake=test -gravitino.use-single-metalake=false +# Optional: omit gravitino.metalake to load every metalake +gravitino.use-single-metalake=true Review Comment: It seems like gravitino.use-single-metalake is @Deprecated; its own description says "Use gravitino.catalog-name-with-metalake instead", and usesDeprecatedSingleMetalakeKey() exists specifically so its use can be reported. This PR changes the value rather than migrating the key ########## dev/docker/trino-connectors/README.md: ########## @@ -181,57 +181,78 @@ configure Basic or OAuth2. In the cluster this is usually `http://{service}.{namespace}.svc.cluster.local:8090`. A published HTTPS URL works the same way; it is not tied to the auth type. +`gravitino.metalake` is optional. Omit it (or leave it empty) to load catalogs +from every metalake. Set it when you want a single metalake only. + `gravitino.client.authType` accepts `simple`, `basic`, `oauth2`, or `kerberos`. The OAuth2 token path key is `gravitino.client.oauth2.path`. ### Basic +On a multi-node Trino cluster, also map the password to an env var (see +[Worker credentials](#worker-credentials-on-a-distributed-cluster)) and set +that env var on every pod. + ```properties connector.name=gravitino gravitino.uri=http://gravitino.example.svc.cluster.local:8090 -gravitino.metalake=test -gravitino.use-single-metalake=false +# Optional: omit gravitino.metalake to load every metalake +gravitino.use-single-metalake=true gravitino.client.authType=basic Review Comment: This example won't work as written. gravitino.client.authType=basic plus an Iceberg catalog fails at registration: REST routing is on by default, basic is in AUTH_TYPES_WITHOUT_REST_CATALOG_EQUIVALENT, so validateRestCatalogAuthentication() throws GRAVITINO_MISSING_CONFIG unless gravitino.iceberg.rest-catalog.security is set explicitly. Either add gravitino.iceberg.rest-catalog.security=NONE (or real-ish IRC credentials), or drop the gravitino.iceberg.rest-uri line as nothing else in the Basic block is Iceberg-specific. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
