FANNG1 commented on code in PR #13390:
URL: https://github.com/apache/gravitino/pull/13390#discussion_r4080445659
##########
lance/lance-common/src/main/java/org/apache/gravitino/lance/common/ops/gravitino/LanceDataTypeConverter.java:
##########
@@ -203,6 +203,10 @@ public ArrowType fromGravitino(Type type) {
@Override
public Type toGravitino(Field arrowField) {
+ if (arrowField.getMetadata() != null &&
!arrowField.getMetadata().isEmpty()) {
+ return toExternalType(arrowField);
+ }
Review Comment:
Good catch. `List`/`Map`/`Union` children are rebuilt with fixed names and
no metadata, so any metadata in their subtree is now handled by keeping the
whole field as Arrow JSON. Struct children keep their names and are still
converted recursively. Added round-trip tests for a list `item` child, map
`entries`, and union children carrying metadata.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
