geyanggang opened a new pull request, #13479:
URL: https://github.com/apache/gravitino/pull/13479

   ### What changes were proposed in this pull request?
   
   Cherry-pick of #13470 to `branch-1.3`.
   
   Adds `COPY README.md /README.md` to the three connector image Dockerfiles so 
the
   connector-image usage documentation ships inside the image:
   
   - `dev/docker/trino-connectors/Dockerfile`
   - `dev/docker/flink-connectors/Dockerfile`
   - `dev/docker/spark-connectors/Dockerfile`
   
   Existing `/licenses` handling and the Trino version-band
   `LICENSE`/`NOTICE`/`README.md` under `/connectors/trino-*/` are unchanged. 
The
   new `/README.md` is at a different path and does not conflict with the band
   README.
   
   ### Why are the changes needed?
   
   The connector images only ship the connector packages, the entrypoint and
   `/licenses`; the image usage README is not included, so users cannot read
   install/usage docs from the image itself.
   
   Fix: #13461
   
   ### Does this PR introduce _any_ user-facing change?
   
   Yes. Users can read the usage documentation from the image, e.g.
   `docker run --rm --entrypoint cat <image> /README.md`.
   
   ### How was this patch tested?
   
   Clean cherry-pick of #13470 (no conflicts). Verified the `COPY README.md 
/README.md`
   line is present in all three Dockerfiles and that each build context contains
   `README.md`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to