Copilot commented on code in PR #13469:
URL: https://github.com/apache/gravitino/pull/13469#discussion_r4080572252
##########
docs/kafka-catalog.md:
##########
@@ -48,6 +48,13 @@ Refer to [Schema
operation](./manage-messaging-metadata-using-gravitino.md#schem
- The Kafka catalog supports creating, updating, deleting, and listing topics.
+::::caution Topic names containing dots
+When authorization is enabled, topic names containing dots are unsupported,
and one such topic can
+cause the entire topic list request to fail. See
+[Names containing dots](./security/access-control.md#names-containing-dots)
for details and the
+workaround.
+::::
Review Comment:
The PR description says the limitation also affects \"topic discovery in
Explore\", but this change set only mentions load/list behavior (and the
access-control section discusses list APIs generally). Either update the docs
to explicitly mention the Explore impact (and where it manifests), or adjust
the PR description to match what’s actually documented.
##########
docs/security/access-control.md:
##########
@@ -73,6 +73,21 @@ Everything Gravitino manages is an object with a type and a
name. The name is th
below the metalake, so a table is `{catalog}.{schema}.{table}`, and requests
identify an object by
both type and name, since the same name can exist at more than one type.
+##### Names containing dots
+
+::::caution
+When authorization is enabled, Gravitino cannot authorize a federated object
whose local name
+contains a dot (`.`), because dots separate the components of a qualified
metadata object name.
Review Comment:
The section title and wording mix singular/plural (`contains a dot` vs
`containing dots`). To avoid ambiguity (e.g., one vs multiple dots), consider
consistently stating that names containing one or more dots (`.`) are
unsupported, while keeping the emphasis on the *local name* (as you do on line
79) so readers don’t confuse this with qualified names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
