xxubai commented on code in PR #12641:
URL: https://github.com/apache/gravitino/pull/12641#discussion_r4079644664
##########
flink-connector/flink-common/src/main/java/org/apache/gravitino/flink/connector/jdbc/GravitinoJdbcCatalogFactory.java:
##########
Review Comment:
nit: make the common provider factories abstract (and preferably make this
hook abstract), leaving only the version-specific factories concrete.
```suggestion
protected abstract Catalog newCatalog(
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
