mchades commented on code in PR #12831:
URL: https://github.com/apache/gravitino/pull/12831#discussion_r4089754358
##########
core/src/main/java/org/apache/gravitino/catalog/ManagedSemanticModelOperations.java:
##########
@@ -80,24 +95,51 @@ public SemanticModel createSemanticModel(
Map<String, String> properties)
throws NoSuchSchemaException, SemanticModelAlreadyExistsException,
IllegalSemanticModelException {
- // TODO: Implement when SemanticModelEntity is available.
- throw new UnsupportedOperationException(
- "createSemanticModel: SemanticModelEntity is not yet implemented");
+ Preconditions.checkArgument(properties != null, "Properties must not be
null");
+
+ writeValidator.accept(ident, definition);
Review Comment:
Catalog-backed source validation has been removed, so `writeValidator` is
now deterministic and cannot import source entities. An existence pre-check
would add a store read while remaining subject to a create race, so
`store.put(..., false)` remains the authoritative conflict check. Entity IDs
are opaque and need not be contiguous.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
