jerryshao commented on code in PR #13501: URL: https://github.com/apache/gravitino/pull/13501#discussion_r4091981999
########## .github/workflows/label-fix-version.yml: ########## @@ -0,0 +1,149 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +# Label the issues fixed by a merged PR with the version that the PR's base +# branch is going to release, e.g. main (2.0.0-SNAPSHOT) -> "2.0.0", +# branch-1.2 (1.2.2-SNAPSHOT) -> "1.2.2". If a release on the base branch is +# still in progress (RC tagged but not released), that release is used +# instead, e.g. branch-1.3 (1.3.2-SNAPSHOT, v1.3.1-rc2 only) -> "1.3.1". +# Unassigned issues are also assigned to the PR author. +# +# Issues are taken only from "[#123]" in the PR title and from the PR's +# closing keywords (e.g. "Fix: #123"). PRs without an issue are skipped. +# +# This uses pull_request_target so that PRs from forks get a token that can +# write labels. It never checks out PR code, and all PR-controlled values are +# passed through env to avoid script injection. + +name: Label issues with fix version and assign author + +on: + pull_request_target: + types: [closed] + +permissions: + issues: write + pull-requests: read + contents: read + +jobs: + label-fix-version: + if: github.event.pull_request.merged == true + runs-on: ubuntu-latest + steps: + - name: Label linked issues + env: + GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} + REPO: ${{ github.repository }} + PR_NUMBER: ${{ github.event.pull_request.number }} + PR_TITLE: ${{ github.event.pull_request.title }} + BASE_REF: ${{ github.event.pull_request.base.ref }} + PR_AUTHOR: ${{ github.event.pull_request.user.login }} + PR_AUTHOR_TYPE: ${{ github.event.pull_request.user.type }} + run: | + set -euo pipefail + + # 1. Collect issue numbers from the title and closing keywords. Title + # ids may come as "[#1][#2]", "[#1 ][#2]" or "[#1, #2]"; the trailing + # "(#PR)" is not in brackets and is ignored. + TITLE_ISSUES=$(printf '%s' "$PR_TITLE" | grep -oE '\[[^]]*\]' | grep -oE '#[0-9]+' \ + | tr -d '#' || true) + CLOSING_ISSUES=$(gh api graphql \ + -F owner="${REPO%/*}" -F name="${REPO#*/}" -F number="$PR_NUMBER" \ + -f query=' + query($owner: String!, $name: String!, $number: Int!) { + repository(owner: $owner, name: $name) { + pullRequest(number: $number) { + closingIssuesReferences(first: 50) { + nodes { number repository { nameWithOwner } } + } + } + } + }' \ + --jq '.data.repository.pullRequest.closingIssuesReferences.nodes[] + | select(.repository.nameWithOwner == env.REPO) | .number' || true) + ISSUES=$(printf '%s\n%s\n' "$TITLE_ISSUES" "$CLOSING_ISSUES" | grep -E '^[0-9]+$' | sort -un || true) + + if [ -z "$ISSUES" ]; then + echo "No linked issue found for PR #$PR_NUMBER, skipping." + exit 0 + fi + + # 2. Resolve the version to be released from the base branch. + VERSION=$(gh api "repos/$REPO/contents/gradle.properties?ref=$BASE_REF" --jq '.content' \ + | base64 -d | sed -n 's/^version[[:space:]]*=[[:space:]]*//p' | tr -d '[:space:]' \ + | sed 's/-SNAPSHOT$//') + if ! printf '%s' "$VERSION" | grep -qE '^[0-9]+\.[0-9]+\.[0-9]+$'; then + echo "Unexpected version '$VERSION' on $BASE_REF, skipping." + exit 0 + fi + + # The release script bumps to the next SNAPSHOT right after tagging an + # RC, so while a release is being voted (RC tag exists but the final + # tag doesn't), fixes still target that release, e.g. 1.3.2-SNAPSHOT + # with v1.3.1-rc2 but no v1.3.1 -> "1.3.1". + TAGS=$(gh api --paginate "repos/$REPO/git/matching-refs/tags/v${VERSION%.*}." \ + --jq '.[].ref | sub("^refs/tags/v"; "")') + PENDING=$(printf '%s\n' "$TAGS" | sed -n 's/-rc[0-9]*$//p' | sort -uV \ Review Comment: Good catch. Dropped the "RC tagged but not released" guess. A merge now gets the version of its merge commit (the next SNAPSHOT during a vote), and a new `label-on-rc` job runs when `vX.Y.Z-rcN` (Nā„2) is pushed: it moves the issues fixed in `rc(N-1)..rcN` to X.Y.Z and removes the next-version label unless the issue was fixed again after the RC. A fix that lands after the last RC keeps the next version. _š¤ Addressed by [Claude Code](https://claude.com/claude-code)_ ########## .github/workflows/label-fix-version.yml: ########## @@ -0,0 +1,149 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +# Label the issues fixed by a merged PR with the version that the PR's base +# branch is going to release, e.g. main (2.0.0-SNAPSHOT) -> "2.0.0", +# branch-1.2 (1.2.2-SNAPSHOT) -> "1.2.2". If a release on the base branch is +# still in progress (RC tagged but not released), that release is used +# instead, e.g. branch-1.3 (1.3.2-SNAPSHOT, v1.3.1-rc2 only) -> "1.3.1". +# Unassigned issues are also assigned to the PR author. +# +# Issues are taken only from "[#123]" in the PR title and from the PR's +# closing keywords (e.g. "Fix: #123"). PRs without an issue are skipped. +# +# This uses pull_request_target so that PRs from forks get a token that can +# write labels. It never checks out PR code, and all PR-controlled values are +# passed through env to avoid script injection. + +name: Label issues with fix version and assign author + +on: + pull_request_target: + types: [closed] + +permissions: + issues: write + pull-requests: read + contents: read + +jobs: + label-fix-version: + if: github.event.pull_request.merged == true + runs-on: ubuntu-latest + steps: + - name: Label linked issues + env: + GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} + REPO: ${{ github.repository }} + PR_NUMBER: ${{ github.event.pull_request.number }} + PR_TITLE: ${{ github.event.pull_request.title }} + BASE_REF: ${{ github.event.pull_request.base.ref }} + PR_AUTHOR: ${{ github.event.pull_request.user.login }} + PR_AUTHOR_TYPE: ${{ github.event.pull_request.user.type }} + run: | + set -euo pipefail + + # 1. Collect issue numbers from the title and closing keywords. Title + # ids may come as "[#1][#2]", "[#1 ][#2]" or "[#1, #2]"; the trailing + # "(#PR)" is not in brackets and is ignored. + TITLE_ISSUES=$(printf '%s' "$PR_TITLE" | grep -oE '\[[^]]*\]' | grep -oE '#[0-9]+' \ + | tr -d '#' || true) + CLOSING_ISSUES=$(gh api graphql \ + -F owner="${REPO%/*}" -F name="${REPO#*/}" -F number="$PR_NUMBER" \ + -f query=' + query($owner: String!, $name: String!, $number: Int!) { + repository(owner: $owner, name: $name) { + pullRequest(number: $number) { + closingIssuesReferences(first: 50) { + nodes { number repository { nameWithOwner } } + } + } + } + }' \ + --jq '.data.repository.pullRequest.closingIssuesReferences.nodes[] + | select(.repository.nameWithOwner == env.REPO) | .number' || true) + ISSUES=$(printf '%s\n%s\n' "$TITLE_ISSUES" "$CLOSING_ISSUES" | grep -E '^[0-9]+$' | sort -un || true) + + if [ -z "$ISSUES" ]; then + echo "No linked issue found for PR #$PR_NUMBER, skipping." + exit 0 + fi + + # 2. Resolve the version to be released from the base branch. + VERSION=$(gh api "repos/$REPO/contents/gradle.properties?ref=$BASE_REF" --jq '.content' \ Review Comment: The version is now read from `gradle.properties` at `merge_commit_sha`, and a commit only maps to an earlier release when an RC of that release contains it (compare API), so rerunning the same merge event always gives the same result. _š¤ Addressed by [Claude Code](https://claude.com/claude-code)_ ########## .github/workflows/label-fix-version.yml: ########## @@ -0,0 +1,149 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +# Label the issues fixed by a merged PR with the version that the PR's base +# branch is going to release, e.g. main (2.0.0-SNAPSHOT) -> "2.0.0", +# branch-1.2 (1.2.2-SNAPSHOT) -> "1.2.2". If a release on the base branch is +# still in progress (RC tagged but not released), that release is used +# instead, e.g. branch-1.3 (1.3.2-SNAPSHOT, v1.3.1-rc2 only) -> "1.3.1". +# Unassigned issues are also assigned to the PR author. +# +# Issues are taken only from "[#123]" in the PR title and from the PR's +# closing keywords (e.g. "Fix: #123"). PRs without an issue are skipped. +# +# This uses pull_request_target so that PRs from forks get a token that can +# write labels. It never checks out PR code, and all PR-controlled values are +# passed through env to avoid script injection. + +name: Label issues with fix version and assign author + +on: + pull_request_target: + types: [closed] + +permissions: + issues: write + pull-requests: read + contents: read + +jobs: + label-fix-version: + if: github.event.pull_request.merged == true + runs-on: ubuntu-latest + steps: + - name: Label linked issues + env: + GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} + REPO: ${{ github.repository }} + PR_NUMBER: ${{ github.event.pull_request.number }} + PR_TITLE: ${{ github.event.pull_request.title }} + BASE_REF: ${{ github.event.pull_request.base.ref }} + PR_AUTHOR: ${{ github.event.pull_request.user.login }} + PR_AUTHOR_TYPE: ${{ github.event.pull_request.user.type }} + run: | + set -euo pipefail + + # 1. Collect issue numbers from the title and closing keywords. Title + # ids may come as "[#1][#2]", "[#1 ][#2]" or "[#1, #2]"; the trailing + # "(#PR)" is not in brackets and is ignored. + TITLE_ISSUES=$(printf '%s' "$PR_TITLE" | grep -oE '\[[^]]*\]' | grep -oE '#[0-9]+' \ + | tr -d '#' || true) + CLOSING_ISSUES=$(gh api graphql \ + -F owner="${REPO%/*}" -F name="${REPO#*/}" -F number="$PR_NUMBER" \ + -f query=' + query($owner: String!, $name: String!, $number: Int!) { + repository(owner: $owner, name: $name) { + pullRequest(number: $number) { + closingIssuesReferences(first: 50) { Review Comment: Closing keywords are now parsed from the PR body directly (GitHub's close/fix/resolve forms), so they work for release-branch PRs as well. _š¤ Addressed by [Claude Code](https://claude.com/claude-code)_ ########## .github/workflows/label-fix-version.yml: ########## @@ -0,0 +1,149 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +# Label the issues fixed by a merged PR with the version that the PR's base +# branch is going to release, e.g. main (2.0.0-SNAPSHOT) -> "2.0.0", +# branch-1.2 (1.2.2-SNAPSHOT) -> "1.2.2". If a release on the base branch is +# still in progress (RC tagged but not released), that release is used +# instead, e.g. branch-1.3 (1.3.2-SNAPSHOT, v1.3.1-rc2 only) -> "1.3.1". +# Unassigned issues are also assigned to the PR author. +# +# Issues are taken only from "[#123]" in the PR title and from the PR's +# closing keywords (e.g. "Fix: #123"). PRs without an issue are skipped. +# +# This uses pull_request_target so that PRs from forks get a token that can +# write labels. It never checks out PR code, and all PR-controlled values are +# passed through env to avoid script injection. + +name: Label issues with fix version and assign author + +on: + pull_request_target: + types: [closed] + +permissions: + issues: write + pull-requests: read + contents: read + +jobs: + label-fix-version: + if: github.event.pull_request.merged == true + runs-on: ubuntu-latest + steps: + - name: Label linked issues + env: + GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} + REPO: ${{ github.repository }} + PR_NUMBER: ${{ github.event.pull_request.number }} + PR_TITLE: ${{ github.event.pull_request.title }} + BASE_REF: ${{ github.event.pull_request.base.ref }} + PR_AUTHOR: ${{ github.event.pull_request.user.login }} + PR_AUTHOR_TYPE: ${{ github.event.pull_request.user.type }} + run: | + set -euo pipefail + + # 1. Collect issue numbers from the title and closing keywords. Title + # ids may come as "[#1][#2]", "[#1 ][#2]" or "[#1, #2]"; the trailing + # "(#PR)" is not in brackets and is ignored. + TITLE_ISSUES=$(printf '%s' "$PR_TITLE" | grep -oE '\[[^]]*\]' | grep -oE '#[0-9]+' \ + | tr -d '#' || true) Review Comment: Brackets now only accept `#N`, commas and whitespace, so `[docs #42]` is ignored while `[#1][#2]`, `[#1 ][#2]` and `[#1, #2]` still work. _š¤ Addressed by [Claude Code](https://claude.com/claude-code)_ ########## .github/workflows/label-fix-version.yml: ########## @@ -0,0 +1,149 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +# Label the issues fixed by a merged PR with the version that the PR's base +# branch is going to release, e.g. main (2.0.0-SNAPSHOT) -> "2.0.0", +# branch-1.2 (1.2.2-SNAPSHOT) -> "1.2.2". If a release on the base branch is +# still in progress (RC tagged but not released), that release is used +# instead, e.g. branch-1.3 (1.3.2-SNAPSHOT, v1.3.1-rc2 only) -> "1.3.1". +# Unassigned issues are also assigned to the PR author. +# +# Issues are taken only from "[#123]" in the PR title and from the PR's +# closing keywords (e.g. "Fix: #123"). PRs without an issue are skipped. +# +# This uses pull_request_target so that PRs from forks get a token that can +# write labels. It never checks out PR code, and all PR-controlled values are +# passed through env to avoid script injection. + +name: Label issues with fix version and assign author + +on: + pull_request_target: + types: [closed] + +permissions: + issues: write + pull-requests: read + contents: read + +jobs: + label-fix-version: + if: github.event.pull_request.merged == true + runs-on: ubuntu-latest + steps: + - name: Label linked issues + env: + GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} + REPO: ${{ github.repository }} + PR_NUMBER: ${{ github.event.pull_request.number }} + PR_TITLE: ${{ github.event.pull_request.title }} + BASE_REF: ${{ github.event.pull_request.base.ref }} + PR_AUTHOR: ${{ github.event.pull_request.user.login }} + PR_AUTHOR_TYPE: ${{ github.event.pull_request.user.type }} + run: | + set -euo pipefail + + # 1. Collect issue numbers from the title and closing keywords. Title + # ids may come as "[#1][#2]", "[#1 ][#2]" or "[#1, #2]"; the trailing + # "(#PR)" is not in brackets and is ignored. + TITLE_ISSUES=$(printf '%s' "$PR_TITLE" | grep -oE '\[[^]]*\]' | grep -oE '#[0-9]+' \ + | tr -d '#' || true) + CLOSING_ISSUES=$(gh api graphql \ + -F owner="${REPO%/*}" -F name="${REPO#*/}" -F number="$PR_NUMBER" \ + -f query=' + query($owner: String!, $name: String!, $number: Int!) { + repository(owner: $owner, name: $name) { + pullRequest(number: $number) { + closingIssuesReferences(first: 50) { + nodes { number repository { nameWithOwner } } Review Comment: The GraphQL query is gone; closing keywords are parsed from the PR body, so there's no page limit. _š¤ Addressed by [Claude Code](https://claude.com/claude-code)_ ########## .github/workflows/label-fix-version.yml: ########## @@ -0,0 +1,149 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +# Label the issues fixed by a merged PR with the version that the PR's base +# branch is going to release, e.g. main (2.0.0-SNAPSHOT) -> "2.0.0", +# branch-1.2 (1.2.2-SNAPSHOT) -> "1.2.2". If a release on the base branch is +# still in progress (RC tagged but not released), that release is used +# instead, e.g. branch-1.3 (1.3.2-SNAPSHOT, v1.3.1-rc2 only) -> "1.3.1". +# Unassigned issues are also assigned to the PR author. +# +# Issues are taken only from "[#123]" in the PR title and from the PR's +# closing keywords (e.g. "Fix: #123"). PRs without an issue are skipped. +# +# This uses pull_request_target so that PRs from forks get a token that can +# write labels. It never checks out PR code, and all PR-controlled values are +# passed through env to avoid script injection. + +name: Label issues with fix version and assign author + +on: + pull_request_target: + types: [closed] + +permissions: + issues: write + pull-requests: read + contents: read + +jobs: + label-fix-version: + if: github.event.pull_request.merged == true + runs-on: ubuntu-latest + steps: + - name: Label linked issues + env: + GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} + REPO: ${{ github.repository }} + PR_NUMBER: ${{ github.event.pull_request.number }} + PR_TITLE: ${{ github.event.pull_request.title }} + BASE_REF: ${{ github.event.pull_request.base.ref }} + PR_AUTHOR: ${{ github.event.pull_request.user.login }} + PR_AUTHOR_TYPE: ${{ github.event.pull_request.user.type }} + run: | + set -euo pipefail + + # 1. Collect issue numbers from the title and closing keywords. Title + # ids may come as "[#1][#2]", "[#1 ][#2]" or "[#1, #2]"; the trailing + # "(#PR)" is not in brackets and is ignored. + TITLE_ISSUES=$(printf '%s' "$PR_TITLE" | grep -oE '\[[^]]*\]' | grep -oE '#[0-9]+' \ + | tr -d '#' || true) + CLOSING_ISSUES=$(gh api graphql \ + -F owner="${REPO%/*}" -F name="${REPO#*/}" -F number="$PR_NUMBER" \ + -f query=' + query($owner: String!, $name: String!, $number: Int!) { + repository(owner: $owner, name: $name) { + pullRequest(number: $number) { + closingIssuesReferences(first: 50) { + nodes { number repository { nameWithOwner } } + } + } + } + }' \ + --jq '.data.repository.pullRequest.closingIssuesReferences.nodes[] + | select(.repository.nameWithOwner == env.REPO) | .number' || true) Review Comment: Removed with the GraphQL query. The script runs with `set -euo pipefail` and API failures now fail the job. _š¤ Addressed by [Claude Code](https://claude.com/claude-code)_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
