jiangxt2 commented on code in PR #13432:
URL: https://github.com/apache/gravitino/pull/13432#discussion_r4124545671
##########
clients/client-python/gravitino/dto/rel/indexes/json_serdes/index_serdes.py:
##########
@@ -51,5 +53,8 @@ def deserialize(cls, data: dict[str, Any]) -> Index:
index_type = Index.IndexType(data[cls.INDEX_TYPE].upper())
return IndexDTO(
- index_type, data.get(cls.INDEX_NAME), data[cls.INDEX_FIELD_NAMES]
+ index_type,
+ data.get(cls.INDEX_NAME),
+ data[cls.INDEX_FIELD_NAMES],
+ data.get(cls.INDEX_PROPERTIES),
Review Comment:
Fixed in e854af9.
- `IndexSerdes.serialize()` now preserves non-empty properties, with a
compatible default for existing `Index` implementations.
- Annoy and USearch round-trip tests assert the property maps directly; 57
focused Python tests and formatting checks passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
