laserninja commented on PR #13163: URL: https://github.com/apache/gravitino/pull/13163#issuecomment-5876378834
Yes, preserving these declarations as ExternalType is intentional. #10519 predates merged PR #13042, which added ExternalType-to-string fallback in the Spark JDBC, Trino PostgreSQL, and Flink converters. This branch already includes those changes. I added explicit regression cases for numeric(39,0), numeric(2,-3), and numeric(3,5) in all three converters, and documented the tradeoff: these columns expose strings rather than native decimals. Supported decimal declarations remain unchanged, and we avoid silently clamping precision or rounding scale. These tests verify type conversion; they do not establish end-to-end engine scan compatibility for every declaration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
