yuqi1129 commented on code in PR #13603:
URL: https://github.com/apache/gravitino/pull/13603#discussion_r4141873492
##########
core/src/main/java/org/apache/gravitino/catalog/TableOperationDispatcher.java:
##########
@@ -770,7 +773,20 @@ private boolean isSameColumn(Column left, int
columnPosition, ColumnEntity right
&& Objects.equal(left.comment(), right.comment())
&& left.nullable() == right.nullable()
&& left.autoIncrement() == right.autoIncrement()
- && Objects.equal(left.defaultValue(), right.defaultValue());
+ && isSameDefaultValue(left.defaultValue(), right.defaultValue());
+ }
+
+ private boolean isSameDefaultValue(Expression left, Expression right) {
+ // Connector snapshots use DTOs, while relational storage restores API
expressions. Compare
+ // their persisted representation rather than implementation-specific
equals methods.
+ return Objects.equal(toDefaultValueArg(left), toDefaultValueArg(right));
Review Comment:
Do you mean that we need to return false when converting the expression
fails here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
