bharos opened a new pull request, #13640:
URL: https://github.com/apache/gravitino/pull/13640
### What changes were proposed in this pull request?
Three fixes to `agent-skills/gravitino-release/SKILL.md`, found while
running the 1.3.1 release:
1. **The frontmatter was in the wrong place.** The `---` YAML block sat
*after* the 16-line license header, so the `name` and `description` were never
parsed and the skill did not load. Moved to line 1, license header immediately
after.
2. **Added the vote phase.** The skill went straight from Docker to
finalize. The `[VOTE]` / `[RESULT][VOTE]` mails, the 72-hour minimum and the
3-binding-+1 rule were not mentioned anywhere.
3. **Added the GitHub release page.** Every release has one; nothing in
`dev/release/` creates it and the skill never mentioned it.
Also records that `finalize` needs `-r` set to the RC that *passed* the
vote. `release-util.sh:141` derives the RC number as the count of existing
`v<version>-rc*` tags plus one, so after rc1–rc3 it computes 4 and finalize
targets a `dist/dev` path that never existed.
### Why are the changes needed?
The skill did not load, and the parts it did document stopped short of the
steps that actually gate a release.
Part of #13637
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Docs only. Verified `./gradlew rat` approves the reordered file —
`agent-skills/` is not in the RAT excludes, so the reorder was the risk worth
checking:
```
gravitino-release/SKILL.md
header-type: AL
license-family: Apache License Version 2.0
license-approval: true
```
The `-r` behaviour above was read from `dev/release/release-util.sh:136-162`
rather than assumed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
