dennismdejong opened a new pull request, #13666:
URL: https://github.com/apache/gravitino/pull/13666
### What changes were proposed in this pull request?
Adds a reflection-based regression test
(`TestRoleMetaMapper#testSoftDeleteRoleMetaByRoleIdHasNamedParam`) asserting
that `RoleMetaMapper.softDeleteRoleMetaByRoleId` carries `@Param("roleId")` on
its first argument. The `@Param` fix itself is already present in the current
codebase.
### Why are the changes needed?
Issue #10270 reports that a missing `@Param("roleId")` on
`RoleMetaMapper.softDeleteRoleMetaByRoleId` could cause MyBatis named-parameter
binding failures at runtime during role deletion via the REST delete-role path.
The annotation is already in place on `main` (the method now also takes
`@Param("currentVersion")` for OCC), but nothing guarded it from regressing.
This test locks in the named binding.
Fix: #10270
### Does this PR introduce any user-facing change?
No.
### How was this patch tested?
- `./gradlew :core:spotlessApply`
- `./gradlew :core:test --tests
org.apache.gravitino.storage.relational.mapper.TestRoleMetaMapper -PskipITs
-PskipDockerTests=true` (1 test, 0 failures)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
