LuciferYang commented on PR #13438: URL: https://github.com/apache/gravitino/pull/13438#issuecomment-5957055780
Closing this one. The stale registry link is real: `register(name, childRegistry)` attaches a forwarding listener to the source registry and keeps no reference, so it cannot be detached. What I could not find is a production path that exercises it. The catalog sources that do get unregistered create every metric before registration (the JDBC datasource gauges and the fileset cache counters are all in place before `register`), so their registries never gain a metric afterwards. The one source that creates metrics lazily, `EntityChangeLogMetricsSource`, is unregistered only from `RelationalEntityStore.close()` during JVM shutdown, where the reporters are already closing and nothing reads a re-injected metric. There is no path that registers the same source name twice in one JVM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
