LuciferYang commented on issue #13437: URL: https://github.com/apache/gravitino/issues/13437#issuecomment-5957220446
Closing this one. The mechanism in the description is real: `register(name, sourceRegistry)` attaches a forwarding listener to the source registry and keeps no reference, so it cannot be detached. The reproduction steps are not reachable in Gravitino as it stands. The sources that actually get unregistered, the JDBC catalog datasource gauges and the fileset cache counters, create every metric before `register` is called, so their registries never gain a metric afterwards and there is nothing to re-inject. The one source that creates metrics lazily, `EntityChangeLogMetricsSource`, is unregistered only from `RelationalEntityStore.close()` during JVM shutdown, where the reporters are already closing and nothing reads a re-injected metric. No path registers the same source name twice in one JVM, so the `IllegalArgumentException` collision has no trigger either. Closing as not reachable rather than fixed. The proposed fix was #13438, also closed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
