LuciferYang commented on PR #13166: URL: https://github.com/apache/gravitino/pull/13166#issuecomment-5957714563
Reopening. My earlier close reasoning was wrong, and the description here already said why. I assessed the second close as a production-impact question, concluded it is harmless for a real client, and closed on that basis. That is true but beside the point: Caffeine dispatches the removal listener on `ForkJoinPool.commonPool()`, so the second close lands on a pool thread after `close()` has returned. `TestBaseCatalogSecrets` shares one mocked `GravitinoClient` and re-stubs it around a manager close, so when that late close interleaves with the pending stubbing, the case fails with `CannotStubVoidMethodWithReturnValue`. That is a captured failure in #13165, not a hypothetical, and it is what this PR fixes. The use-after-close problem I mentioned in the close comment is a separate bug that this PR does not address, and it will get its own issue rather than being folded in here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
