Copilot commented on code in PR #12870:
URL: https://github.com/apache/gravitino/pull/12870#discussion_r4171280523
##########
core/src/main/java/org/apache/gravitino/tag/TagManager.java:
##########
@@ -84,7 +84,8 @@ public class TagManager implements TagDispatcher {
MetadataObject.Type.TOPIC,
MetadataObject.Type.COLUMN,
MetadataObject.Type.MODEL,
- MetadataObject.Type.FUNCTION);
+ MetadataObject.Type.FUNCTION,
+ MetadataObject.Type.SEMANTIC_MODEL);
Review Comment:
Please add a storage-backed tag round-trip test for an existing Semantic
Model in `TestTagManager`. The new core test stops at failed existence
validation, the REST test mocks `TagManager`, and the cleanup test inserts
relation rows directly. None exercises successful ID resolution and tag
persistence for this target. Persist a `SemanticModelEntity`, make the
existence check succeed, and verify association, list/get, reverse lookup
through `listMetadataObjectsForTag`, and disassociation, following the existing
view/function coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
