dennismdejong commented on code in PR #13671: URL: https://github.com/apache/gravitino/pull/13671#discussion_r4173432992
########## clients/client-python/pylintrc: ########## @@ -99,3 +97,9 @@ module-naming-style=snake_case # Maximum number of return / yield for a function / method body. max-returns=10 + +# Maximum number of arguments for a function / method. +max-args=10 + +# Maximum number of positional arguments for a function / method. +max-positional-arguments=10 Review Comment: The number 10 is not arbitrary — it's the actual maximum argument count in the client-python codebase today. DTO constructors that mirror the Java client carry up to 10 parameters (e.g. `SparkTemplateUpdateDTO.__init__`, `JobTemplateChange.__init__`, and the `DTOConverters` init each take exactly 10), so any threshold below 10 (9) would emit warnings on legitimate public API. Conversely, 11 or higher would let a future function exceed the current maximum without triggering the design rule. 10 is the smallest value that passes the existing API surface — meaning any future function going to 11+ args is flagged — and it also matches the existing `max-returns=10` threshold already set in the same `[DESIGN]` section of the pylintrc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
