Jesshuan commented on PR #12527: URL: https://github.com/apache/gravitino/pull/12527#issuecomment-5981221983
Thanks for this work and this Starburst compatibility Have you ever seen that i've proposed almost the same thing here in june :[merge request 11302]( https://github.com/apache/gravitino/pull/11302) ? I was waiting for an action of you @jerryshao if i remember that @diqiu50 The comments on the code are similar, but perhaps we 've used a similar ai model... Despite of the sensation of having been excluded of this action (but it's probably not your fault, there are a huge numbers of issues and MR on this kind of projects), i've just test the new gravitino version with your Starburst compatibility contribution, and it perfectly works. With my old proposition, the starburst users had to extract a private starburst spi jar to put it on the gravitino-trino-connector for building the project... It i was a rather cumbersome procedure to perform... But i don't really understand why , but with your version, nothing to do: it work without any jar manipulation. I think because i couldn't guess exactly what Starbust spi class was missing , and the jar manipulation was preventing some silent bug. And your version is more exhaustive. Good works ;) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
