roryqi commented on code in PR #12867:
URL: https://github.com/apache/gravitino/pull/12867#discussion_r4214428430
##########
api/src/main/java/org/apache/gravitino/authorization/Privilege.java:
##########
@@ -171,7 +171,13 @@ enum Name {
* credential secrets in the {@code getSecrets} result. Alone it does not
authorize {@code
* getSecrets}. Does not authorize {@code getCredentials}.
*/
- INCLUDE_CREDENTIAL_SECRETS(0L, 1L << 38);
+ INCLUDE_CREDENTIAL_SECRETS(0L, 1L << 38),
+ /** The privilege to create a semantic model. */
+ CREATE_SEMANTIC_MODEL(0L, 1L << 39),
+ /** The privilege to discover a semantic model and load its definition. */
+ SELECT_SEMANTIC_MODEL(0L, 1L << 40),
Review Comment:
The term "select model" implies choosing a model, but it seems the intended
meaning is closer to "use model." In my case, I have permission to access a
specific model — there's a semantic mismatch between the naming and the actual
meaning
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
