jarredhj0214 commented on PR #13550: URL: https://github.com/apache/gravitino/pull/13550#issuecomment-6072648219
Thanks @yuqi1129. Addressed the review in a6c718eaf and updated the PR description: - Hive 3 resolution: chose option 1, with consistent, actionable HMS configuration errors and documentation. The server still needs SerDeStorageSchemaReader configured; the test container now enables it. - Batch loading: single-table and batch reads share the resolution helper in both shims, so only affected tables issue getFields RPCs. Added mixed ordinary/derived table tests and catalog-aware Hive 3 coverage. - Alter behavior: retain the original storage columns for property/comment changes and renames. Column changes on SerDe-derived tables are rejected with guidance to update the SerDe/external schema instead, avoiding silently ineffective changes. Added unit coverage for preservation and rejection. - Integration coverage: added an OpenCSVSerde test inherited by CatalogHive2IT and CatalogHive3IT. It creates and verifies a real HMS marker, loads the table individually and in a batch, checks metadata alters preserve the marker, and checks column changes are rejected. Formatting and all 142 unit tests across hive-metastore-common, hive-metastore3-libs, and catalog-hive passed. The integration test compiled, but I could not execute it locally because Docker is unavailable. Both container runs remain to be validated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
