geyanggang commented on PR #13548: URL: https://github.com/apache/gravitino/pull/13548#issuecomment-6075771794
LGTM. Confirmed `SparkJdbcTypeConverter` maps `ExternalType `to `StringType` with a warn log, so the Spark JDBC path is safe — my earlier concern was looking at the base converter, not the JDBC one. Comments, unit coverage, and the load IT all look good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
