roryqi commented on PR #13478: URL: https://github.com/apache/gravitino/pull/13478#issuecomment-6080380028
Thanks for the detailed review. I considered ANTLR, and I agree with your dependency observation: after moving the implementation into `core`, Spark runtime version conflicts are not the primary reason to avoid it. I kept the recursive-descent implementation because this grammar is small and LL(1), while fail-closed error handling, AST construction, semantic validation, and resource limits would still be custom code with ANTLR. The PR description now states that trade-off explicitly. All inline points are addressed in c98a40c8d4. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
