Copilot commented on code in PR #13785: URL: https://github.com/apache/gravitino/pull/13785#discussion_r4246928276
########## docs/trino-connector/authentication.md: ########## @@ -212,6 +212,20 @@ gravitino.iceberg.rest-catalog.oauth2.scope=email This is a completely separate credential from the one the connector uses against the main Gravitino server; it is not reused automatically. +:::note +With `iceberg.rest-catalog.session=USER`, the IRC is reached with the end user's token only. The +metadata fallback described above does not apply to the IRC: a session without a forwarded token +fails to read or write tables in that catalog instead of using the service credential, even though +the catalog is still listed and its schemas can still be browsed. On open-source Trino this is the +case for every user who signs in through OAuth2, because the coordinator does not forward the token +(see step 1 of the example below). Review Comment: This introduces the acronym \"IRC\" without expanding it in the added note. Since this is a documentation-only change meant to clarify behavior, consider spelling it out on first use in the note (e.g., \"Iceberg REST Catalog (IRC)\") to avoid ambiguity for readers skimming directly to this section. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
