mchades commented on code in PR #13791: URL: https://github.com/apache/gravitino/pull/13791#discussion_r4248689793
########## core/src/main/java/org/apache/gravitino/listener/api/event/semantic/ExportSemanticModelEvent.java: ########## @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.gravitino.listener.api.event.semantic; + +import javax.annotation.Nullable; +import org.apache.gravitino.NameIdentifier; +import org.apache.gravitino.annotation.DeveloperApi; +import org.apache.gravitino.listener.api.event.OperationType; +import org.apache.gravitino.semantic.OssieFormat; + +/** Successful event for exporting a Semantic Model as an Ossie document. */ +@DeveloperApi +public final class ExportSemanticModelEvent extends SemanticModelEvent { + @Nullable private final OssieFormat format; + + /** + * Constructs a {@code ExportSemanticModelEvent}. + * + * @param user The username of the individual who initiated the operation. + * @param identifier The Semantic Model identifier. + * @param format The document format, or null for an invalid request. + */ Review Comment: Removed `@Nullable` and the invalid-request wording from the export success event. Pre/failure events still allow a null format. ########## core/src/main/java/org/apache/gravitino/listener/api/event/semantic/ImportSemanticModelEvent.java: ########## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.gravitino.listener.api.event.semantic; + +import javax.annotation.Nullable; +import org.apache.gravitino.NameIdentifier; +import org.apache.gravitino.annotation.DeveloperApi; +import org.apache.gravitino.listener.api.event.OperationType; +import org.apache.gravitino.listener.api.info.SemanticModelInfo; +import org.apache.gravitino.semantic.OssieFormat; + +/** Successful event for importing an Ossie document as a Semantic Model. */ +@DeveloperApi +public final class ImportSemanticModelEvent extends SemanticModelEvent { + @Nullable private final OssieFormat format; + private final SemanticModelInfo importedSemanticModelInfo; + + /** + * Constructs a {@code ImportSemanticModelEvent}. + * + * @param user The username of the individual who initiated the operation. + * @param identifier The Semantic Model identifier. + * @param format The document format, or null for an invalid request. + * @param importedSemanticModelInfo The imported Semantic Model information. + */ Review Comment: Removed `@Nullable` and the invalid-request wording from the import success event. Pre/failure events still allow a null format. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
