laserninja commented on code in PR #12900:
URL: https://github.com/apache/gravitino/pull/12900#discussion_r4255029426
##########
web-v2/web/src/app/catalogs/rightContent/entitiesContent/SchemaDetailsPage.js:
##########
@@ -631,6 +655,65 @@ export default function SchemaDetailsPage() {
[currentMetalake, catalogType, catalog, schema, catalogData?.provider]
)
+ const semanticModelColumns = useMemo(
+ () => [
+ {
+ title: 'Semantic Model Name',
+ dataIndex: 'name',
+ key: 'name',
+ width: 300,
+ ellipsis: true,
+ sorter: (a, b) =>
a?.name.toLowerCase().localeCompare(b?.name.toLowerCase()),
+ render: name => (
+ <Link
+ data-refer={`semantic-model-link-${name}`}
+
href={`/catalogs?metalake=${encodeURIComponent(currentMetalake)}&catalogType=${catalogType}&catalog=${encodeURIComponent(catalog)}&schema=${encodeURIComponent(schema)}&semanticModel=${encodeURIComponent(name)}`}
+ >
+ {name}
+ </Link>
+ )
+ },
+ {
+ title: 'Tags',
+ dataIndex: 'tags',
+ key: 'tags',
+ render: (_, record) => (
+ <Tags metadataObjectType={'semantic_model'}
metadataObjectFullName={`${catalog}.${schema}.${record.name}`} />
+ )
+ },
+ {
+ title: 'Actions',
+ dataIndex: 'action',
+ key: 'action',
+ width: 100,
+ render: (_, record) => (
+ <Space size={4}>
Review Comment:
Implemented in d428897a5. Semantic Model row actions now include Set Owner
when authorization is enabled, reusing SetOwnerDialog with semantic_model and
the model's full name. Tests cover visibility and the dialog target; a
mocked-browser check changes the owner and verifies the ownership request URL
and payload.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
