roryqi commented on code in PR #13478:
URL: https://github.com/apache/gravitino/pull/13478#discussion_r4255369679
##########
core/src/main/java/org/apache/gravitino/policy/PolicyManager.java:
##########
@@ -341,6 +343,7 @@ private PolicyEntity updatePolicyEntity(PolicyEntity
policyEntity, PolicyChange.
}
newContent.validate();
+ validateReadRestrictionContent(policyEntity.policyType(), newContent);
Review Comment:
Fixed in d3952e83ec. is back inside the arm, while upstream's generic
remains outside the loop. Rename-only and comment-only alters therefore do not
reparse stored restricted Rego. I added a regression test that writes a legacy
row-filter expression directly to the entity store and verifies that both
rename and comment update succeed without changing its content.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
