yuqi1129 commented on PR #13747: URL: https://github.com/apache/gravitino/pull/13747#issuecomment-6144932264
@roryqi Addressed your [concurrent initialization comment](https://github.com/apache/gravitino/pull/13747#issuecomment-6121749492) in 5a067372b0. - Removed `boundRoleSubjects`, `activeRoleSubjects`, and `updateActiveRoleSubjects()`. Subjects are now computed locally from the request's immutable bound-role IDs and prefetched role names, so there is no shared derived set for a late setter to overwrite. - Made prefetch single-flight with a second check under the request monitor, shared with `loadRole()`. The prefetched version map is published after the caches are primed; initialized requests retain the lock-free fast path. - Added `testParallelRequestPrefetchIsSingleFlight` and `testParallelNamedActiveRolesUsePublishedRequestMembership`. They use eight real worker threads and latches, covering concurrent initialization, narrowed ActiveRoles, and DENY from an inactive held role. The existing sequential list-filter test remains separate coverage of the filtering helper. Re-ran both parallel tests and the interleaved request tests on the current head: 6 tests passed, with Spotless passing. The broader targeted authorization validation previously passed 371 tests on this same commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
