roryqi commented on code in PR #13801: URL: https://github.com/apache/gravitino/pull/13801#discussion_r4259382022
########## api/src/main/java/org/apache/gravitino/policy/PolicyExecutionFields.java: ########## @@ -0,0 +1,153 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.gravitino.policy; + +import com.google.common.base.Preconditions; +import com.google.common.collect.ImmutableMap; +import java.util.Collections; +import java.util.LinkedHashMap; +import java.util.Map; +import javax.annotation.Nullable; +import org.apache.commons.lang3.StringUtils; + +/** + * Optional execution peer fields shared by policy contents: triggers, cooldown, and option bags. + * + * <p>JSON property names are stable API keys for policy content documents. + */ +public final class PolicyExecutionFields { + + /** JSON property for {@link TimeTrigger}. */ + public static final String TIME_TRIGGER_JSON_KEY = "timeTrigger"; + + /** JSON property for {@link EventTrigger}. */ + public static final String EVENT_TRIGGER_JSON_KEY = "eventTrigger"; + + /** JSON property for minimum interval between finished runs. */ + public static final String MIN_INTERVAL_MS_JSON_KEY = "minIntervalMs"; + + /** JSON property for job / client options. */ + public static final String JOB_OPTIONS_JSON_KEY = "jobOptions"; + + /** JSON property for updater / control-plane options. */ + public static final String UPDATE_OPTIONS_JSON_KEY = "updateOptions"; Review Comment: I can't get the point why we need this. Yes, I mean it is hard to understand. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
