roryqi commented on code in PR #13771: URL: https://github.com/apache/gravitino/pull/13771#discussion_r4266454117
########## catalogs/catalog-lakehouse-hudi/src/main/java/org/apache/gravitino/catalog/lakehouse/hudi/HudiCatalogCapability.java: ########## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.gravitino.catalog.lakehouse.hudi; + +import org.apache.gravitino.connector.capability.Capability; +import org.apache.gravitino.connector.capability.CapabilityResult; + +/** Describes the capabilities of the Hudi catalog backed by Hive Metastore. */ +public class HudiCatalogCapability implements Capability { + + /** Creates a Hudi catalog capability for the Hive Metastore backend. */ + public HudiCatalogCapability() {} + + @Override + public CapabilityResult caseSensitiveOnName(Scope scope) { + if (scope == Scope.SCHEMA || scope == Scope.TABLE) { + return CapabilityResult.unsupported( + "The Hudi Hive backend is case insensitive for schemas and tables."); Review Comment: Addressed in 69495771f8. Added an Identifier Case Behavior section to both the native Hive and Hudi-HMS catalog docs. The Hive section documents case-insensitive schema, table, and view identifiers. The Hudi section documents case-insensitive schema and table identifiers and notes that its read-only catalog operations do not write identifiers, so external HMS cleanup is required only when an affected object actually carries `gravitino.identifier`. Both sections now describe the catalog-wide force-drop and recreate recovery flow, including which external objects and physical data are retained and the loss/reapplication of Gravitino governance metadata. `./gradlew :docs:build` passes. Leaving this thread unresolved for reviewer confirmation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
