roryqi commented on PR #13814: URL: https://github.com/apache/gravitino/pull/13814#issuecomment-6164005986
`PolicyContentDTO extends PolicyContent` also couples the transport model to the domain model. It forces DTOs to implement domain methods such as `rules`, `properties`, and `validate`, often by constructing a domain object again, and it makes domain defaulting leak into JSON behavior. DTOs should represent the wire contract and convert to an immutable domain content object; they should not themselves be `PolicyContent`. This coupling is separate from, and compounds, the repeated execution-field blocks in the maintenance DTOs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
