LuciferYang opened a new pull request, #13875: URL: https://github.com/apache/gravitino/pull/13875
### What changes were proposed in this pull request? - `IcebergHiveCachedClientPool` no longer implements `Closeable`, and its `close()` is removed. - `ClosableHiveCatalog` drops the `resources` list, `addResource` and the loop in `close()` that closed them, plus the `AutoCloseable` branch in `resetIcebergHiveClientPool`. `closeInternalClientPool` no longer needs to exclude `IcebergHiveCachedClientPool`. ### Why are the changes needed? None of this code runs. `HiveCatalog.initialize` always installs Iceberg's `CachedClientPool` before `resetIcebergHiveClientPool` reads the old pool, and `ClientPool` is not `AutoCloseable`, so the close branch is never taken. `closeInternalClientPool` skips `IcebergHiveCachedClientPool`, and `addResource` has no callers. The removed `close()` was also unsafe to call: it closed every client in the JVM-wide cache and shut down the shared scheduler. Fix: #13871 ### Does this PR introduce _any_ user-facing change? No behavior change. `iceberg-common` is published, so the public methods `IcebergHiveCachedClientPool.close()`, `ClosableHiveCatalog.addResource()` and `ClosableHiveCatalog.getResources()` are gone. Nothing in Gravitino calls them. ### How was this patch tested? `TestIcebergHiveCachedClientPool.testCloseMultipleInstances` is removed with the method it tested. No new test: the removed code is unreachable, so there is no behavior to pin. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
