mchades commented on code in PR #11926: URL: https://github.com/apache/gravitino/pull/11926#discussion_r4282912230
########## docs/trino-connector/sql-support.md: ########## @@ -45,6 +45,33 @@ The connector provides read access and write access to data and metadata stored - [DROP SCHEMA](https://trino.io/docs/current/sql/drop-schema.html) - [COMMENT](https://trino.io/docs/current/sql/comment.html) +### View Management + +- [CREATE VIEW](https://trino.io/docs/current/sql/create-view.html) +- [CREATE OR REPLACE VIEW](https://trino.io/docs/current/sql/create-view.html) +- [SHOW CREATE VIEW](https://trino.io/docs/current/sql/show-create-view.html) +- [DROP VIEW](https://trino.io/docs/current/sql/drop-view.html) +- [ALTER VIEW ... RENAME TO](https://trino.io/docs/current/sql/alter-view.html) + +View management is only supported for catalogs backed by Hive or Iceberg; other catalogs +(e.g. Glue, JDBC, Memory) do not support view operations. A view stored by Gravitino may carry SQL +representations for multiple engines (Hive, Spark, Flink, Trino); the Trino connector only reads and +writes the Trino dialect representation. A view that has no Trino SQL representation is silently +invisible to Trino (it does not appear in `SHOW TABLES`/`information_schema` and cannot be loaded), +rather than causing an error. View owner is not supported; views are always shown with `SECURITY +INVOKER` (Gravitino does not track an owner, so `SECURITY DEFINER` cannot be represented). Review Comment: **[P3] Update the documented view security mode.** This PR now persists and reloads `SECURITY DEFINER` owners, and Trino defaults to DEFINER when the clause is omitted. The statements that owners are unsupported and views are always INVOKER are therefore outdated. Please describe the implemented security modes and current limitations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
