roryqi commented on code in PR #13569: URL: https://github.com/apache/gravitino/pull/13569#discussion_r4294225306
########## NOTICE.bin: ########## @@ -603,6 +603,14 @@ This project includes code from Kite, developed at Cloudera, Inc. with the following copyright notice: Copyright 2013 Cloudera Inc. +This project includes code from Presto, developed at Facebook, with the +following copyright notice: + Copyright 2016 Facebook and contributors. + +This project includes code from Delta Lake, developed at The Delta Lake Project, +with the following copyright notice: + Copyright (2021) The Delta Lake Project Authors. Review Comment: Confirmed. Both the Presto and Delta Lake attributions were added upstream together by apache/iceberg#16543 (merge commit `44d9721e4bfd`) after a LICENSE/NOTICE audit; the derived code already existed and that PR backfilled the missing notices. The pinned Datastrato commit includes that upstream change, and the same text is present in the root `NOTICE` of the packaged `experimental-iceberg-core-1.13.0.jar`. I also checked Delta Lake’s official `NOTICE.txt`, which uses exactly `Copyright (2021) The Delta Lake Project Authors.` Therefore these entries should remain in `NOTICE.bin`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
