yuqi1129 commented on code in PR #13930:
URL: https://github.com/apache/gravitino/pull/13930#discussion_r4323761510
##########
core/src/main/java/org/apache/gravitino/catalog/TableOperationDispatcher.java:
##########
@@ -1012,7 +1015,22 @@ private TableEntity updateColumnsIfNecessaryWhenLoad(
PrincipalUtils.getCurrentPrincipal().getName())
.withLastModifiedTime(Instant.now())
.build())
- .build()),
+ .build());
+ } catch (IOException e) {
+ if (!(UPDATE_ENTITY_CONFLICT_MESSAGE_PREFIX +
id).equals(e.getMessage())) {
Review Comment:
Agreed that a dedicated exception with structured fields would be cleaner.
For this branch-1.3 patch, I'd prefer to keep the change narrowly scoped and
reuse the existing conflict signal, which Lance also relies on. Here we match
the complete message, including the table identifier, and preserve the existing
handling for all other IOExceptions. Would you be comfortable keeping this
approach for the maintenance branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
