Roshan1299 commented on issue #13317:
URL: https://github.com/apache/gravitino/issues/13317#issuecomment-6306197459

   Hi @jerryshao, I'd like to take items 3 and 6 of this list if nobody is on 
them.
   
   - 3: check `defaultCatalog` and `defaultSchema` with 
`EntityFieldLimits.checkMaxLength` in `ViewNormalizeDispatcher.createView` 
before the view is created externally, since both columns are VARCHAR(128).
   - 6: in `MetalakeHookDispatcher.createMetalake`, check the current user name 
against the user name column limit before calling `dispatcher.createMetalake`, 
so a name that is too long fails before anything is created.
   
   Both with unit tests. For item 2, would you prefer the store error to be 
raised to the caller, or the external object to be rolled back? I can do that 
one in a separate PR once that's decided.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to