nevzheng opened a new pull request, #14103: URL: https://github.com/apache/gravitino/pull/14103
### What changes were proposed in this pull request? - 42 test files move from JUnit 4 `org.junit.Assert` to JUnit Jupiter `Assertions`; 123 `assertThrows` and message-argument calls get Jupiter's argument order. - The last two JUnit 4 test classes, `TestGravitinoCatalogStore` (flink-common) and `TestOwnerDetails` (clients/cli), become Jupiter tests. They did not run before under the JUnit Platform; they run now (8 and 2 tests). - No build change: it runs on the JUnit 5.8.1 that `main` uses. The conversion was cross-checked against OpenRewrite's `JUnit4to5Migration` recipe (rewrite-testing-frameworks 3.44.0): both agree on 42 of the 44 files. In `TestTagCommands` the recipe's lambdas do not compile, and in `TestOwnerDetails` this PR uses `assertThrows` instead of the recipe's try/fail/catch. ### Why are the changes needed? These files compile only because Testcontainers 1.x brings `junit:junit` onto the test classpath. Testcontainers 2 (#14084) drops it, and JUnit 6 (#14083) is easier to review without them, so this PR lands first and on its own. Fix: #14001 ### Does this PR introduce _any_ user-facing change? No. Test code only. ### How was this patch tested? `compileTestJava` with -Werror for every touched module on JUnit 5.8.1; their unit tests, 1,979 tests, 0 failures; no `org.junit.<Class>` (JUnit 4) import left. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
