roryqi commented on code in PR #13778: URL: https://github.com/apache/gravitino/pull/13778#discussion_r4346294043
########## iceberg/iceberg-rest-server-experiment/src/main/java/org/apache/gravitino/iceberg/service/restriction/ExperimentalIcebergReadRestrictionLoader.java: ########## @@ -0,0 +1,288 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.gravitino.iceberg.service.restriction; + +import java.security.Principal; +import java.util.ArrayList; +import java.util.Collections; +import java.util.HashMap; +import java.util.HashSet; +import java.util.LinkedHashMap; +import java.util.List; +import java.util.Map; +import java.util.Optional; +import java.util.Set; +import org.apache.gravitino.Entity; +import org.apache.gravitino.GravitinoEnv; +import org.apache.gravitino.MetadataObject; +import org.apache.gravitino.NameIdentifier; +import org.apache.gravitino.UserGroup; +import org.apache.gravitino.UserPrincipal; +import org.apache.gravitino.authorization.AccessControlDispatcher; +import org.apache.gravitino.exceptions.NoSuchGroupException; +import org.apache.gravitino.iceberg.common.utils.IcebergIdentifierUtils; +import org.apache.gravitino.iceberg.service.authorization.IcebergRESTServerContext; +import org.apache.gravitino.listener.api.event.IcebergRequestContext; +import org.apache.gravitino.meta.PolicyEntity; +import org.apache.gravitino.policy.ColumnMaskContent; +import org.apache.gravitino.policy.Policy; +import org.apache.gravitino.policy.PolicyDispatcher; +import org.apache.gravitino.policy.RowFilterContent; +import org.apache.gravitino.policy.rego.RestrictedRegoExpressionParserFacade; +import org.apache.gravitino.policy.rego.RestrictedRegoProgram.ColumnMask; +import org.apache.gravitino.policy.rego.RestrictedRegoProgram.RowFilter; +import org.apache.gravitino.utils.HierarchicalSchemaUtil; +import org.apache.gravitino.utils.NameIdentifierUtil; +import org.apache.gravitino.utils.PrincipalUtils; +import org.apache.iceberg.Schema; +import org.apache.iceberg.TableMetadata; +import org.apache.iceberg.catalog.TableIdentifier; +import org.apache.iceberg.rest.responses.LoadTableResponse; +import org.apache.iceberg.rest.restrictions.ReadRestrictions; +import org.apache.iceberg.rest.restrictions.ReadRestrictionsParser; +import org.apache.iceberg.types.Types; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** Loads tag-selected Gravitino policies into experimental Iceberg read restrictions. */ +public final class ExperimentalIcebergReadRestrictionLoader + implements IcebergReadRestrictionLoader { + private static final Logger LOG = + LoggerFactory.getLogger(ExperimentalIcebergReadRestrictionLoader.class); + + /** Creates the service-loaded read-restriction loader. */ + public ExperimentalIcebergReadRestrictionLoader() {} + + @Override + public Result load( + IcebergRequestContext context, TableIdentifier tableIdentifier, LoadTableResponse response) { + GravitinoEnv environment = GravitinoEnv.getInstance(); + PolicyDispatcher policyDispatcher = environment.internalPolicyDispatcher(); + if (policyDispatcher == null) { + return Result.of(response, Optional.empty()); + } Review Comment: Fixed in 0346f27b6e. The experimental loader now reports enabled only when GravitinoEnv has an internal policy dispatcher. Standalone Iceberg REST deployments without one can use the metadata-location conditional GET fast path again; deployments with policies still resolve the full response before checking the ETag. Added a test for both states, and the experimental module tests pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
