lasdf1234 opened a new pull request, #14232:
URL: https://github.com/apache/gravitino/pull/14232

   ### What changes were proposed in this pull request?
   
   - Exclude reserved+hidden properties (e.g. `gravitino.identifier`) from 
`SecretPropertyUtils.shouldRecoverSensitiveNamedSecret` / `buildSecrets`
   - Align docs with `HiddenPropertyMaskUtils` omit semantics
   - Add unit coverage
   
   ### Why are the changes needed?
   
   `getSecrets` treated every declared hidden property as recoverable, so the 
internal `gravitino.identifier` leaked into secret responses.
   
   Fix: #14231
   
   ### Does this PR introduce _any_ user-facing change?
   
   Yes — `getSecrets` no longer returns reserved+hidden internal keys such as 
`gravitino.identifier`. Real hidden secrets (e.g. `jdbc-password`) are 
unchanged.
   
   ### How was this patch tested?
   
   `./gradlew :core:test --tests 
org.apache.gravitino.secret.TestSecretPropertyUtils -PskipITs`
   
   Made with [Cursor](https://cursor.com)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to