jerryshao commented on code in PR #14230:
URL: https://github.com/apache/gravitino/pull/14230#discussion_r4377118304
##########
core/src/main/java/org/apache/gravitino/connector/job/JobExecutor.java:
##########
@@ -189,9 +189,11 @@ default boolean isJobStateNodeLocal() {
* @param jobId The unique identifier of the job.
* @param maxLines The maximum number of (most recent) lines to return,
resolved by the caller
* from the {@code gravitino.job.outputMaxLines} configuration.
- * @param maxBytes The maximum number of (most recent) bytes to read from
the underlying output,
- * resolved by the caller from the {@code gravitino.job.outputMaxBytes}
configuration. Bounds
- * both the read cost and the response size regardless of how the
content is shaped.
+ * @param maxBytes The maximum number of (most recent) bytes to return,
resolved by the caller
+ * from the {@code gravitino.job.outputMaxBytes} configuration. Bounds
the response size
+ * regardless of how the content is shaped. An implementation should
also bound the bytes it
+ * reads from the underlying output when it can, but may not, for
example when the output can
+ * only be read by lines.
Review Comment:
Fixed in da419bb3b8: `JobOperationDispatcher#getJob` now says the bytes to
return, and the comment in `JobManager#getJob` only claims a bound on the
response size.
_🤖 Addressed by [Claude Code](https://claude.com/claude-code)_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
