mchades commented on code in PR #14145:
URL: https://github.com/apache/gravitino/pull/14145#discussion_r4402107842
##########
clients/client-java/src/main/java/org/apache/gravitino/client/SemanticModelCatalogOperations.java:
##########
@@ -260,6 +299,18 @@ private Namespace getSemanticModelFullNamespace(Namespace
semanticModelNamespace
return Namespace.of(catalogNamespace.level(0), catalogName,
semanticModelNamespace.level(0));
}
+ private static String formatMetricRequestPath(Namespace namespace) {
+ return BaseSchemaCatalog.formatSchemaRequestPath(
+ Namespace.of(namespace.level(0), namespace.level(1)))
+ + "/"
+ + RESTUtils.encodeString(namespace.level(2))
+ + "/semantic-model-metrics";
+ }
+
+ private static Namespace relativeMetricNamespace(Namespace namespace) {
Review Comment:
`Namespace.level()` already validates the position and throws
`IllegalNamespaceException`, which extends `IllegalArgumentException`. The
four-level namespace is defined by the REST contract, and this conversion
follows the existing table, function, and semantic-model listing APIs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
