lasdf1234 commented on code in PR #14462:
URL: https://github.com/apache/gravitino/pull/14462#discussion_r4439700974
##########
iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/iceberg/service/CatalogWrapperForREST.java:
##########
@@ -719,4 +742,34 @@ private static void replaceDeprecatedProperties(
properties.put(newProperty, deprecatedValue);
}
}
+ /**
+ * Iceberg's plan response serializer refers to delete files by their
location. Deletion vectors
+ * that share one Puffin file have the same location, so every task would
refer to whichever of
+ * them was indexed last, and a client would apply the wrong deletion
vector. Such a plan is
+ * refused rather than answered wrongly.
+ */
+ @VisibleForTesting
+ static void checkDeleteFilesCanBeReferenced(
+ TableIdentifier tableIdentifier, List<FileScanTask> fileScanTasks) {
Review Comment:
Could u rename to validateDeleteFileLocations? May be this name is better
than checkDeleteFilesCanBeReferenced
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
