laserninja commented on PR #14455: URL: https://github.com/apache/gravitino/pull/14455#issuecomment-6567965103
Should we preserve the existing fast path for an empty pageToken with no pageSize, after validating the size? The Iceberg Java client sends pageToken="" and omits pageSize by default. Previously, this returned the complete list directly; the new condition makes it sort everything first, repeatedly allocating identifier strings. In a Java 17 microbenchmark with 100k shuffled table identifiers, helper processing increased from ~0.03 ms to ~225 ms, with ~617 MB of transient allocation. Keeping both early-return cases would preserve this fix without slowing ordinary unbounded listings. Otherwise, the functional behavior looks correct. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
