lasdf1234 commented on PR #14556: URL: https://github.com/apache/gravitino/pull/14556#issuecomment-6602526382
### Bugbot-style review summary Posted **5 inline comments** on Lance changes in this PR: | Severity | Topic | |----------|--------| | P1 | Unknown/unimplemented routes → `INVALID_INPUT` instead of `Unsupported` (code 0 / 406) | | P1 | Test locks in that `INVALID_INPUT` behavior | | P2 | Client 400 `detail` may include stack traces via `errorDetail` | | P3 | Expected client errors logged at ERROR | | P3 | Same body code `INVALID_INPUT` with HTTP 404 vs 400 | **Out of this PR’s diff (Iceberg already on main):** storage mapping gaps (Aliyun OSS / S3 `NoSuchKey` → 500, 403 → 503) and broad NPE/ISE → 400 — noted for follow-up, not inlined here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
