diqiu50 commented on code in PR #14561:
URL: https://github.com/apache/gravitino/pull/14561#discussion_r4456526918
##########
catalogs/catalog-glue/src/main/java/org/apache/gravitino/catalog/glue/GlueCatalogOperations.java:
##########
@@ -725,7 +1091,25 @@ private boolean matchesFormatFilter(Table table) {
}
String normalized =
fmt != null ? fmt.toLowerCase(Locale.ROOT) :
GlueConstants.DEFAULT_TABLE_FORMAT_VALUE;
- return tableFormatFilter.contains(normalized);
+ return isFormatVisible(normalized);
Review Comment:
Glue is a Hive-compatible metastore, and Delta tables registered by other
engines are Hive-style table entries in it, so the catalog treats every table
without `table-format` and without `table_type=ICEBERG` as `hive`, as the Hive
catalog does for Delta tables in HMS. `delta` and `parquet` only match tables
that carry that `table-format`. I documented this classification in the
`table-format-filter` description instead of adding native format detection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
