lasdf1234 commented on code in PR #14659:
URL: https://github.com/apache/gravitino/pull/14659#discussion_r4489948441
##########
catalogs/catalog-lakehouse-iceberg/src/main/java/org/apache/gravitino/catalog/lakehouse/iceberg/converter/ConvertUtil.java:
##########
@@ -76,9 +89,109 @@ public static IcebergColumn
fromNestedField(Types.NestedField nestedField) {
.withNullable(nestedField.isOptional())
.withComment(nestedField.doc())
.withType(IcebergDataTypeConverter.CONVERTER.toGravitino(nestedField.type()))
+ .withDefaultValue(
+ fromIcebergLiteral(
+ nestedField.writeDefaultLiteral(),
Review Comment:
Thanks for catching this. Restored the optimizer runtime alignment:
`maintenance/optimizer` now uses Spark 3.5 / Iceberg 1.11 (same as
`maintenance/jobs` and lakehouse-iceberg), so IsolatedClassLoader's shared
`org.apache.iceberg.*` types include `writeDefaultLiteral()` /
`initialDefaultLiteral()`.
Verified locally:
```
./gradlew :maintenance:optimizer:test --tests '*GravitinoTableMetaIT'
-PskipTests -PskipDockerTests=true
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]