geyanggang opened a new pull request, #14726:
URL: https://github.com/apache/gravitino/pull/14726

   ### What changes were proposed in this pull request?
   - Add `netty` (4.1.140.Final) and `xnio` (3.8.17.Final) to the version 
catalog, plus a `netty-bom` entry.
   - catalog-glue: apply the Netty BOM in a dedicated configuration 
(`isCanBeConsumed = false`, `isCanBeResolved = false`) extended only by the 
module's own compile/runtime/test classpaths. All Netty artifacts brought in by 
the AWS SDK move together (4.1.118 -> 4.1.140) and nothing is exported to 
dependent modules.
   - server-common and iceberg-common: add a constraint for `xnio-api` where 
the Kerby bundle (which pulls it in through `kerb-admin`) is declared. The same 
constraint reaches the server `libs`, iceberg-rest-server, 
iceberg-rest-server-experiment and catalog-lakehouse-iceberg. `xnio-api` 3.8.17 
has the same transitive versions as 3.8.8, so only that one jar changes.
   - dev/release/maven/README.md: note Netty 4.1.140. NOTICE and the companion 
license texts are identical to the audited 4.1.118, so `dependencies.txt` needs 
no change.
   
   Not changed on purpose:
   - `libs`: netty-buffer and netty-common 4.1.119 come from Lance via Arrow, 
whose `arrow-memory-netty-buffer-patch` overrides internal `io.netty.buffer` 
classes built against a specific Netty.
   - Hive metastore libs already resolve Netty 4.1.138 through ZooKeeper.
   - The `aws-bundle` and `azure-bundle` artifacts relocate their own Netty 
(4.1.86 from the SDK v1 fat jar in `aws-java-sdk-bundle`, 4.1.110 from the 
Azure SDK). They are not part of the server distribution and are left for a 
separate change.
   
   ### Why are the changes needed?
   Routine dependency maintenance: keep these transitive dependencies on the 
latest patch release of their lines.
   
   Fix: #14725
   
   ### Does this PR introduce _any_ user-facing change?
   No.
   
   ### How was this patch tested?
   - Compared the full `distribution/package` jar list before and after: only 
the 11 Glue Netty jars (4.1.118 -> 4.1.140) and the 4 `xnio-api` copies (3.8.8 
-> 3.8.17) changed. The standalone `gravitino-iceberg-rest-server` distribution 
gets the new `xnio-api` as well.
   - spotlessCheck, testMavenLegalFiles and generateBundledLegalFiles pass.
   - Unit tests pass for catalog-glue, iceberg-common, iceberg-rest-server, 
catalog-lakehouse-iceberg and server. 
`TestHttpsServerAuthentication.testMutualTlsRejectsMissingClientCertificate` in 
server-common fails the same way on an unmodified upstream/main (local 
environment).
   - Integration tests in deploy mode pass (`-PskipTests=false 
-PskipDockerTests=false -PtestMode=deploy`): MotoGlueCatalogIT (35), 
IcebergRESTMemoryCatalogIT, IcebergRESTJdbcCatalogIT, IcebergRESTHiveCatalogIT, 
CatalogIcebergRestIT.
   - Ran the AWS SDK Netty async client (`NettyNioAsyncHttpClient`) from the 
Glue `libs` directory against a Moto server: create database, create table, 
list tables and databases succeed, and the loaded Netty is 4.1.140.
   - Not covered: TLS/HTTP2 through the Netty client, and a real AWS endpoint.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to