LuciferYang commented on code in PR #14643:
URL: https://github.com/apache/gravitino/pull/14643#discussion_r4505391945


##########
spark-connector/spark-common/src/main/java/org/apache/gravitino/spark/connector/jdbc/GravitinoJdbcCatalog.java:
##########
@@ -53,6 +53,9 @@ protected TableCatalog createAndInitSparkCatalog(
     Map<String, String> all =
         getPropertiesConverter().toSparkCatalogProperties(options, properties);
     applyJdbcCredential(gravitinoCatalogClient, all);
+    if (useTimestampNtz()) {
+      all.put("preferTimestampNTZ", "true");

Review Comment:
   Confirmed for catalog-level settings: with the Spark option in either case, 
or with `spark.bypass.preferTimestampNTZ`, the reader keeps a single key and 
agrees with the converter on all three builds. A per-read option still gets 
through; see my new comment on `SparkJdbcTable` line 87.



##########
spark-connector/spark-common/src/main/java/org/apache/gravitino/spark/connector/jdbc/SparkJdbcTable.java:
##########
@@ -99,4 +145,51 @@ public StructType schema() {
   public Map<String, String> properties() {
     return gravitinoTableInfoHelper.properties();
   }
+
+  private static boolean hasUnsafePushDown(JDBCTable table, Table source) {
+    for (Column column : source.columns()) {
+      Type type = column.dataType();
+      if (type instanceof Types.StringType

Review Comment:
   Confirmed: `ORDER BY tags LIMIT 1` returns id 2 and `max(tags)` returns 
`{a}` on 3.5.3 and 4.0.3, and neither is pushed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to