mchades commented on code in PR #14659:
URL: https://github.com/apache/gravitino/pull/14659#discussion_r4489870965
##########
catalogs/catalog-lakehouse-iceberg/src/main/java/org/apache/gravitino/catalog/lakehouse/iceberg/converter/ConvertUtil.java:
##########
@@ -76,9 +89,109 @@ public static IcebergColumn
fromNestedField(Types.NestedField nestedField) {
.withNullable(nestedField.isOptional())
.withComment(nestedField.doc())
.withType(IcebergDataTypeConverter.CONVERTER.toGravitino(nestedField.type()))
+ .withDefaultValue(
+ fromIcebergLiteral(
+ nestedField.writeDefaultLiteral(),
Review Comment:
[P1] Preserve compatibility with the optimizer's Iceberg runtime
Calling `writeDefaultLiteral()` here breaks table loading in the optimizer's
embedded integration tests. Their runtime still includes
`iceberg-spark-runtime-3.3_2.12:1.8.1`, which does not provide this method;
even a table without defaults fails with `NoSuchMethodError`. `./gradlew
:maintenance:optimizer:test --tests '*GravitinoTableMetaIT'
-PskipDockerTests=true` passes at the PR merge base `21b9c6e` and fails at
`e817d0a`. The [Maintenance CI
job](https://github.com/lasdf1234/gravitino/actions/runs/42175195378/job/127752258841)
reports the same error. Please align the runtime API versions or use a
compatible conversion before calling these accessors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]